refactor: improve code quality and fix naming conventions - #2
Open
Dinnerb0ne2 wants to merge 1 commit into
Open
Conversation
Dinnerb0ne2
commented
Mar 22, 2026
Dinnerb0ne2
commented
- Rename get_current_time_tostring to get_current_time_to_string
- Fix CRTP template parameter from DerviceLogger to DerivedLogger
- Add runtime boundary checks in FileLogBuffer::write()
- Improve buffer safety and code maintainability
- Rename get_current_time_tostring to get_current_time_to_string - Fix CRTP template parameter from DerviceLogger to DerivedLogger - Add runtime boundary checks in FileLogBuffer::write() - Improve buffer safety and code maintainability
Owner
|
gitinore,vcpkg.json和cmake文件别动，其他ok。我的本意是header-only,方便集成，包管理模式不是我要管的事情 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.